Skip to content

Introduce new utils repo #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

alimaredia
Copy link
Contributor

No description provided.

@alimaredia alimaredia requested a review from a team March 12, 2025 12:00
@nathan-weinberg nathan-weinberg requested review from a team March 12, 2025 12:50
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up Ali - I've noticed there's no proposed alternatives seen in other dev-docs - curious why we would not simply add such scripts somewhere such as here or here?

I'm also a little concerned that if we make a scripts repo then folks will focus moreso on hacking scripts together than making actual functional improvements to ilab - it seems like some of the pain points you mentioned could be addressed as actual code changes. Could you speak a little more to this?

@derekhiggins
Copy link

How about increasing the scope to be more general purpose (maybe named "support-utils" or "support-scripts"?)

There would be a low barrier to entry, allowing anyone to contribute without worrying about API compatibility or long-term commitments,

The structure could include a subdirectory for "data-generation" but also
"debug-utilities", "ci-utilities", "dev-env-setup" etc...

As people use the scripts and improve them, it will become clear which ones are essential (the cream will float to the top), at which point it could graduate to one of the main repositories

@alimaredia
Copy link
Contributor Author

@derekhiggins I've changed the proposal to have the repo name to support-utils. I think some of the ideas for the structure you mentioned are great, and I hope the repo evolves that way as scripts are added.

Copy link
Contributor

@courtneypacheco courtneypacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This idea makes sense to me.

@courtneypacheco
Copy link
Contributor

We have 4 approvals, 1 of which is an oversight committee approval. Going to merge this.

@courtneypacheco courtneypacheco merged commit b26782e into instructlab:main Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants