-
Notifications
You must be signed in to change notification settings - Fork 25
Implement leaderboard as a benchmark #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121a86f
to
4806e00
Compare
bbrowning
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming, the failing unit test around StrEnum
import is figured out, this looks good. The new code is purely additive, and the extra requirements are in a separate requirements txt file so it shouldn't cause any issues with downstream builds.
1cb9078
to
0d5a983
Compare
…but this brings the core idea Signed-off-by: Oleg Silkin <[email protected]>
Signed-off-by: Oleg Silkin <[email protected]>
Signed-off-by: Oleg Silkin <[email protected]>
Signed-off-by: Oleg Silkin <[email protected]>
…ptions for the `simple_evaluate` function Signed-off-by: Oleg Silkin <[email protected]>
Signed-off-by: Oleg Silkin <[email protected]>
Signed-off-by: Oleg Silkin <[email protected]>
…uctlab-eval[leaderboard] Signed-off-by: Oleg Silkin <[email protected]>
Signed-off-by: Oleg Silkin <[email protected]>
0d5a983
to
6651188
Compare
6651188
to
1e40fc6
Compare
Signed-off-by: Oleg Silkin <[email protected]>
1e40fc6
to
66fb8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
Affects CI/CD configuration
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
one-approval
testing
Relates to testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes the Open LLM Leaderboard v2 to become an evaluation exposed within instructlab/eval.
In particular, this exposes leaderboard with the ability for users to select a subset of the tasks in leaderboard.
In addition, this benchmark is implemented in a way such that it runs each subtask on the most optimal inference backend for a given task.
Specifically, MCQ-style tasks (GPQA, MUSR, MMLU-Pro, and BBH) are executed directly through regular HF transformers, whereas generative tasks (IFEval and MATH-Hard) get executed through vLLM.