Update Docling version and improve OCR options handling with new docling ver. #574
+59
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th bumped ver. Signed-off-by: eshwarprasadS <[email protected]>
eshwarprasadS
requested review from
bbrowning,
aakankshaduggal and
khaledsulayman
mergify
bot
added
CI/CD
Signed-off-by: eshwarprasadS <[email protected]>
Signed-off-by: eshwarprasadS <[email protected]>
aakankshaduggal
approved these changes
Mar 19, 2025
Comment on lines
+185
to
+186
| if filepaths: | ||
| return filepaths |
There was a problem hiding this comment.
I understand this change and it makes sense, but I'm surprised the existing unit tests didn't break. The difference here is we're returning 1 variable rather than 2. Usually Python complains when the number of expected outputs from a function doesn't match the number of outputs it actually received.
It sounds like our existing unit tests don't have enough coverage. I'm a bit concerned that we might run into unexpected behavior.
There was a problem hiding this comment.
I dug a little deeper and it looks like the existing logic is technically unaffected by this change, but can we add a unit test to validate the outputs of this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to bump the version of
doclingfromdocling>=2.4.2,<=2.8.3todocling>=2.18.0. This is to bring in the fix for the particular docling chunking failure issue on markdowns with unescaped special characters (docling-project/docling#823)The primary changes are:
requirements.txttox.iniandchunkers.pydocling.parseintaxonomy.py, since the pdf parsed doc content is not necessary to be passed toDocumentChunker