Skip to content

Knowledge: add knowledge of China Great Wall #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leidwang
Copy link

@leidwang leidwang commented Jun 20, 2025

Add knowledge about the Great Wall of China

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Jun 20, 2025
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands.

@leidwang leidwang changed the title Knowledge: add knowledge of China Greate Wall Knowledge: add knowledge of China Great Wall Jun 26, 2025
@yanghangliu
Copy link

I tried asking Granite a question "what's the Great Wall of China" and got the following answer:

# ilab  model chat ~/.cache/instructlab/models/instructlab/granite-7b-lab
>>> What's the Great Wall of China ? 
...
The Great Wall of China is a series of fortifications made of stone, brick, tamped earth, wood, and other materials, built across the historical northern borders of China to protect against invasions. The wall is a remarkable architectural feat, stretching over 13,000 miles (20,972 kilometers) and passing through 23 provinces.

The construction of the Great Wall is believed to have begun in the 7th century BCE, during the Shang Dynasty, and continued through the Western Zhou, Eastern Zhou, and Han Dynasties. The wall was expanded and fortified during the Ming Dynasty, between 1368 and 1644, which saw the most extensive construction and renovation work.

The Great Wall was not a single, continuous structure, but rather a series of walls, trenches, watchtowers, and other fortifications built to protect the Chinese people from invasions by nomadic tribes from the steppes. The wall was also used for transportation, communication, and military purposes.

Today, the Great Wall of China is a UNESCO World Heritage Site and is one of the most popular tourist attractions in the world. The wall is a symbol of Chinese history, culture, and national identity, and is a testament to the ingenuity and determination of the Chinese people.

Overall, the Great Wall of China is a remarkable and fascinating architectural feat that has stood the test of time and continues to inspire awe and admiration.

Seems it's a known knowledge by Granite?

@leidwang
Copy link
Author

I tried asking Granite a question "what's the Great Wall of China" and got the following answer:

# ilab  model chat ~/.cache/instructlab/models/instructlab/granite-7b-lab
>>> What's the Great Wall of China ? 
...
The Great Wall of China is a series of fortifications made of stone, brick, tamped earth, wood, and other materials, built across the historical northern borders of China to protect against invasions. The wall is a remarkable architectural feat, stretching over 13,000 miles (20,972 kilometers) and passing through 23 provinces.

The construction of the Great Wall is believed to have begun in the 7th century BCE, during the Shang Dynasty, and continued through the Western Zhou, Eastern Zhou, and Han Dynasties. The wall was expanded and fortified during the Ming Dynasty, between 1368 and 1644, which saw the most extensive construction and renovation work.

The Great Wall was not a single, continuous structure, but rather a series of walls, trenches, watchtowers, and other fortifications built to protect the Chinese people from invasions by nomadic tribes from the steppes. The wall was also used for transportation, communication, and military purposes.

Today, the Great Wall of China is a UNESCO World Heritage Site and is one of the most popular tourist attractions in the world. The wall is a symbol of Chinese history, culture, and national identity, and is a testament to the ingenuity and determination of the Chinese people.

Overall, the Great Wall of China is a remarkable and fascinating architectural feat that has stood the test of time and continues to inspire awe and admiration.

Seems it's a known knowledge by Granite?

From my perspective, the knowledge we contribute doesn't have to be novel or unknown to InstructLab. Rather, our goal is to enhance the model's output by contribute knowledge.

@leidwang
Copy link
Author

@instructlab-bot precheck

Copy link

User leidwang is not allowed to run the InstructLab bot. Only [taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee] teams are allowed to access the bot functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knowledge (Auto labeled) triage-needed (Auto labeled) skill is ready to be triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants