Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/#538/seed example addition error #542

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aevo98765
Copy link
Member

No description provided.

…utton within button error. Skill form.

Signed-off-by: Ash Evans <[email protected]>
…utton within button error. Knowledge Native form.

Signed-off-by: Ash Evans <[email protected]>
@vishnoianil
Copy link
Member

@aevo98765 Thanks for the PR and welcome back !!

Few review comments:

  • This change needs to go in github knowledge form as well.
  • The current delete buttons takes more real state compared to old one, wondering if we can think of something that doesn't require the form area to shirnk.
  • Is this error specific to the local environment (when ran in npm dev mode)? because qa.ui.instructlab.ai doesn't throw any error when i add seed example to both skill and knowledge.

Existing form:
Screenshot 2025-02-03 at 10 15 00 PM

Change in this PR:
Screenshot 2025-02-03 at 10 14 37 PM

Signed-off-by: Ash Evans <[email protected]>
…elete button takes. Also only rendering the delete button on accordion collapse

Signed-off-by: Ash Evans <[email protected]>
@aevo98765
Copy link
Member Author

I have changed this so: 1) The delete button is only displayed when the accordion is closed. 2) Changed the layout proportions so that the delete button takes up less room.

@aevo98765
Copy link
Member Author

Yeh it looks like when the project is built and started then this error does not occur. Happy to just have this error existing if the end user is never going to encounter it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants