[CLX-3251][Horizon] Redesign AI assist #3468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR renames "AI Assist" to "IgniteAI" throughout the Horizon module and implements deep linking for citation sources in the AI assistant chat. Overall, the changes are well-structured and follow the project's architectural patterns.
Positive Highlights
- Consistent Rebranding: The rename from "AI Assist" to "IgniteAI" is thorough across UI strings, accessibility labels, and content descriptions
- Deep Linking Implementation: Good addition of navigation to citation sources, enabling users to access referenced content directly
- UI Improvements: The new input design with cleaner styling and better visual hierarchy improves the user experience
- Chip Cleanup Logic: Smart addition of clearing chip options when sending new messages prevents UI clutter
- Color Updates: The new AI gradient colors (
#9E58BDto#00828E) provide better visual distinction
Issues Found
- Typo in Enum:
UNKOWNshould beUNKNOWNinJourneyAssistCitationType(libs/canvas-api-2/.../JourneyAssistCitation.kt:36) - Missing Null/Unknown Handling:
toDeepLink()function doesn't properly handle unknown source types, which could generate invalid URLs (libs/horizon/.../AiAssistMessage.kt:64) - Hardcoded String: "Enter a prompt" is hardcoded instead of using the existing string resource (libs/horizon/.../AiAssistTextArea.kt:74)
- Removed Feedback Feature: The thumbs up/down feedback UI has been removed from response blocks - confirm this is intentional (libs/horizon/.../AiAssistResponseTextBlock.kt:100)
Testing Recommendations
- Test deep link navigation with all citation types (wiki pages, attachments, unknown)
- Verify the AI assistant works correctly with the
mainNavControllernavigation changes - Test that chip options properly clear when new messages are sent
- Ensure accessibility strings are read correctly with screen readers
Architecture & Code Quality
- Follows MVVM pattern correctly with proper separation of concerns
- Navigation changes properly thread
mainNavControllerthrough the component hierarchy - Enum serialization change to use
@SerializedNameis the correct approach for Gson/Retrofit - UI changes align with Jetpack Compose best practices
The PR is in good shape with minor issues that should be addressed before merging.
...anvas-api-2/src/main/java/com/instructure/canvasapi2/models/journey/JourneyAssistCitation.kt
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/instructure/horizon/features/aiassistant/common/model/AiAssistMessage.kt
Show resolved
Hide resolved
.../com/instructure/horizon/features/aiassistant/common/composable/AiAssistResponseTextBlock.kt
Show resolved
Hide resolved
...main/java/com/instructure/horizon/features/aiassistant/common/composable/AiAssistTextArea.kt
Show resolved
Hide resolved
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Fri, 09 Jan 2026 09:52:54 GMT |
|
Student Install Page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: CLX-3251
affects: Student
release note: Career - Redesigned IgniteAI experience.