SG Refactor #3 - Extract submission grader logic to view model #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18708 affects: Teacher release note: none test plan:
…-extraction # Conflicts: # Teacher/Teacher.xcodeproj/project.pbxproj # Teacher/Teacher/SpeedGrader/Grading/Rubrics/View/RubricAssessor.swift
…ared. refs: MBL-18708 affects: Student, Teacher, Parent release note: none test plan: none
refs: MBL-18708 affects: Teacher release note: none test plan:
vargaat
requested review from
szabinst,
rh12,
ndrsszsz and
suhaibabsi-inst
as code owners
Teacher Build QR Code: |
… the one currently on screen.
refs: MBL-18708 affects: Teacher release note: none test plan: - Test if attempt switching works correctly.
vargaat
force-pushed
the
chore/MBL-18708-SubmissionGrader-refactor
branch
from
fc69c00 to
c0c9fa0
Compare
rh12
reviewed
Apr 15, 2025
Teacher/Teacher/SpeedGrader/MainLayout/View/SubmissionGraderView.swift
Outdated
Show resolved
Hide resolved
Teacher/Teacher/SpeedGrader/MainLayout/View/SubmissionGraderView.swift
Outdated
Show resolved
Hide resolved
vargaat
changed the title
…o chore/MBL-18708-SubmissionGrader-refactor # Conflicts: # Teacher/Teacher/SpeedGrader/StudentPager/View/SpeedGraderViewController.swift
…o chore/MBL-18708-SubmissionGrader-refactor
…refactor # Conflicts: # Core/Core/Common/Extensions/Foundation/StringExtensions.swift # Core/Core/Features/Assignments/APIRubricCriterion.swift # Core/Core/Features/Assignments/Rubric.swift # Core/Core/Resources/Database.xcdatamodeld/Database.xcdatamodel/contents # Teacher/Teacher.xcodeproj/project.pbxproj # Teacher/Teacher/SpeedGrader/Grading/Rubrics/Model/RubricGradingInteractor.swift # Teacher/Teacher/SpeedGrader/Grading/Rubrics/ViewModel/Ratings/RubricCustomRatingViewModel.swift # Teacher/Teacher/SpeedGrader/Grading/Rubrics/ViewModel/Ratings/RubricRatingViewModel.swift # Teacher/Teacher/SpeedGrader/Grading/Rubrics/ViewModel/RubricCriterionViewModel.swift
…o chore/MBL-18708-SubmissionGrader-refactor
rh12
previously approved these changes
Apr 16, 2025
Base automatically changed from
chore/MBL-18708-SpeedGraderViewController-refactor
to
master
April 17, 2025 08:35
vargaat
dismissed stale reviews from ndrsszsz and rh12
The base branch was changed.
rh12
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-18708
affects: Teacher
release note: none
test plan:
Checklist