forked from flutter-webrtc/flutter-webrtc
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crashes on old MacOS versions #147
Open
evdokimovs
wants to merge
10
commits into
main
Choose a base branch
from
macos-old-systems-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…macos-old-systems-support
evdokimovs
added
enhancement
Improvement of existing features or bugfix
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
platform::macos
Specific to macOS platform
labels
Jan 25, 2024
FCM
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
platform::macos
Specific to macOS platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
It was discovered that
flutter-webrtc
crashes on old MacOS versions (< 10.15
). The problem arises from the utilization of the newerAVCaptureDeviceDiscoverySession
API, which is not supported on these legacy systems.We've opted for the newer API since the old one is deprecated and doesn't function correctly on the more recent versions of MacOS.
Solution
To address this, we can add a conditional check based on the MacOS version where the code is executed. This involves using an
if
statement to determine the appropriate API to call, like so:However, simply adding this conditional check can lead to a program crash at the start, triggered by
dyld
, as it cannot locate symbols of the newer API during the initial execution. To mitigate this, it is necessary to instruct the compiler to weakly link the system library containing the new API. Weakly linking the library means that symbol checks will be not performed at startup, avoiding a crash. Since theif
statement ensures that the code for the new API is never executed on older systems, this approach will not crash a program.Checklist
k::
labels applied