Skip to content

Conversation

@martindurant
Copy link
Member

@martindurant martindurant commented Jul 10, 2024

breaking changes in some behaviour (but most were broken anyway)

reimplements patterns and auth

requires intake/intake#837

most tests fixed, not all; some removed

breaking changes in some behaviour (but most were broken anyway)

reimplements patterns and auth

requires intake/intake#837
@juntyr
Copy link

juntyr commented Nov 13, 2024

Thank you for working on this!

@martindurant martindurant changed the title RFC: update to intake2 Update to intake2 Nov 13, 2024
@martindurant martindurant merged commit 719a7c8 into intake:master Nov 13, 2024
5 checks passed
@martindurant martindurant deleted the intake2 branch November 13, 2024 21:26
@juntyr
Copy link

juntyr commented Nov 14, 2024

Wow, thank you for getting this PR merged so quickly! Is there a (rough) time plan for when a new version will be released? I'd just like to know, there is no time pressure on my end :)

@martindurant
Copy link
Member Author

There's no reason not to release now, except that anyone still installing intake-xarray will now get intake2 and something might break.

@juntyr
Copy link

juntyr commented Nov 26, 2024

There's no reason not to release now, except that anyone still installing intake-xarray will now get intake2 and something might break.

Could you release a new major version so that downstream packages depending on intake-xarray would have to explicitly upgrade to the new version (anyone that doesn't bound the dependency version in some way [ideally semantic versioning] explicitly opts into breaking changes imo)? I'm on the other side of the issue where I need to use intake v2 and am looking forward to the release

@martindurant
Copy link
Member Author

We could call it 1.0.0, then. Or actually 2.0.0, to match intake - but it might be the last one, since you don't really need intake-xarray any more, except for backward compatibility!

This was referenced Dec 2, 2024
@martindurant
Copy link
Member Author

2.0.0 released. They might not be any more, depending on whether people decide to migrate to straight intake2 usage.

@juntyr
Copy link

juntyr commented Dec 12, 2024

2.0.0 released. They might not be any more, depending on whether people decide to migrate to straight intake2 usage.

Thanks for the release and the ping!

@juntyr juntyr mentioned this pull request Jan 21, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants