Fixes a typo LoraAdapterRequest -> LoRAAdapterRequest and reorganize vllm docker image to actually build local src #13125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirel
changed the title
kirel
commented
May 1, 2025
| docker build \ | ||
| --build-arg http_proxy=.. \ | ||
| --build-arg https_proxy=.. \ | ||
| --build-arg no_proxy=.. \ | ||
| --rm --no-cache -t intelanalytics/ipex-llm-serving-xpu:latest . | ||
| --rm --no-cache \ |
There was a problem hiding this comment.
The no-cache is becoming less relevant when building from local src - if there are changes it will be rebuilt.
kirel
commented
May 5, 2025
| COPY python/llm /llm/llm | ||
| # Install ipex-llm from the copied local source directory, using the extra index for dependencies | ||
| RUN set -eux && \ | ||
| pip install --pre /llm/llm[xpu_2.6] --extra-index-url https://download.pytorch.org/whl/xpu |
There was a problem hiding this comment.
Most important line - install from local source tree instead of package registry.
|
Closing as per discussion in #13124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo
LoraAdapterRequest->LoRAAdapterRequest