Skip to content

Add BLE support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPHutchins merged 1 commit into from
Nov 16, 2024
Merged

Add BLE support #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions smpmgr/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from smp.exceptions import SMPBadStartDelimiter
from smpclient import SMPClient
from smpclient.generics import SMPRequest, TEr1, TEr2, TRep
from smpclient.transport.ble import SMPBLETransport
from smpclient.transport.serial import SMPSerialTransport

logger = logging.getLogger(__name__)
Expand All @@ -24,6 +25,7 @@
@dataclass(frozen=True)
class TransportDefinition:
port: str | None
ble: str | None


@dataclass(frozen=True)
Expand All @@ -48,6 +50,12 @@ def get_custom_smpclient(options: Options, smp_client_cls: Type[TSMPClient]) ->
)
else:
return smp_client_cls(SMPSerialTransport(), options.transport.port)
elif options.transport.ble is not None:
logger.info(f"Initializing SMPClient with the SMPBLETransport, {options.transport.ble=}")
return smp_client_cls(
SMPBLETransport(),
options.transport.ble,
)
else:
typer.echo(
f"A transport option is required; "
Expand Down
3 changes: 2 additions & 1 deletion smpmgr/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def options(
port: str = typer.Option(
None, help="The serial port to connect to, e.g. COM1, /dev/ttyACM0, etc."
),
ble: str = typer.Option(None, help="The Bluetooth address to connect to"),
timeout: float = typer.Option(
2.0, help="Transport timeout in seconds; how long to wait for requests"
),
Expand All @@ -69,7 +70,7 @@ def options(

setup_logging(loglevel, logfile)

ctx.obj = Options(timeout=timeout, transport=TransportDefinition(port=port), mtu=mtu)
ctx.obj = Options(timeout=timeout, transport=TransportDefinition(port=port, ble=ble), mtu=mtu)
logger.info(ctx.obj)

if ctx.invoked_subcommand is None:
Expand Down