Skip to content

fix(spec): remove updatedAt from incoming and outgoing payment resources #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2025

Conversation

marclevin
Copy link
Contributor

Changes proposed in this pull request

Removed updatedAt from incoming and outgoing payment resources in the RS spec

Context

Removed the updatedAt field from the incoming and outgoing payment resources in the resource-server.yaml specification. Regenerated the TypeScript types to reflect these changes.

Closes #532

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for openpayments-preview canceled.

Name Link
🔨 Latest commit 0cf782f
🔍 Latest deploy log https://app.netlify.com/sites/openpayments-preview/deploys/67d980d689114a00085d808b

Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marclevin, thanks for the contribution! 🙂 Changes look good, you'll just have to merge main in your branch (I made some schema/type changes).

Also, since we are removing a field, this would be a breaking change for the open-payments client. We can do a major version bump (via a changeset). In the root of the repo, run pnpm changeset:add and go through the steps to do so

Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 0cf782f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@interledger/open-payments Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marclevin
Copy link
Contributor Author

Thanks for the review @mkurapov. I added the changeset and marked it as a major version bump for both the open-payments and openapi packages since removing a field is a breaking change. Let me know if this is okay.

Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final thing!

@marclevin
Copy link
Contributor Author

Thanks a bunch, done.

@mkurapov mkurapov merged commit a163bd6 into interledger:main Mar 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove updatedAt from spec
2 participants