-
Notifications
You must be signed in to change notification settings - Fork 41
fix(spec): remove updatedAt from incoming and outgoing payment resources #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for openpayments-preview canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marclevin, thanks for the contribution! 🙂 Changes look good, you'll just have to merge main in your branch (I made some schema/type changes).
Also, since we are removing a field, this would be a breaking change for the open-payments client. We can do a major version bump (via a changeset). In the root of the repo, run pnpm changeset:add
and go through the steps to do so
🦋 Changeset detectedLatest commit: 0cf782f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for the review @mkurapov. I added the changeset and marked it as a major version bump for both the |
Co-authored-by: Max Kurapov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final thing!
Thanks a bunch, done. |
Changes proposed in this pull request
Removed updatedAt from incoming and outgoing payment resources in the RS spec
Context
Removed the updatedAt field from the incoming and outgoing payment resources in the resource-server.yaml specification. Regenerated the TypeScript types to reflect these changes.
Closes #532