chore: update openapi-typescript #567
Merged
+1,906
−1,554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b995c05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openpayments-preview canceled.
|
mkurapov
commented
Mar 14, 2025
| @@ -1115,6 +1117,7 @@ components: | |||
| description: The total amount successfully received (by all receivers) using the current outgoing payment grant. | |||
| metadata: | |||
| type: object | |||
| additionalProperties: true | |||
There was a problem hiding this comment.
to allow generating
{
[key: string]: unknown;
}instead of Record<string, never>
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the flag @sidvishnoi! added PR: #581
mkurapov
commented
Mar 14, 2025
| @@ -149,6 +149,7 @@ paths: | |||
| identifier: 'http://ilp.interledger-test.dev/bob' | |||
| client: 'https://webmonize.com/.well-known/pay' | |||
| description: '' | |||
| required: true | |||
There was a problem hiding this comment.
requestbody is required for grant requests. (to generate proper type)
raducristianpopa
approved these changes
Mar 17, 2025
# Conflicts: # packages/open-payments/package.json # pnpm-lock.yaml
mkurapov
force-pushed
the
249/mk/update-openapi-ts
branch
from
a741d21 to
b995c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
openapi-typescriptto latest versionrequestBodyrequired in grant request (to generate correct types)additionalProperties: truein spec where necessaryContext
Fixes #249