Skip to content

Conversation

viveksahu26
Copy link
Contributor

This PR adds the following changes:

  • Decoupled Sequential and Concurrent Fetching:

    • Previously, both sequential and concurrent modes relied on fetchSBOMFromReleases, which used concurrent downloading (3 goroutines) even for sequential fetching. This PR separates them:
      • Sequential mode now downloads SBOMs one-by-one, i.e. sequential processing.
      • Concurrent mode performs a concurrency limit of 3 downloads.
  • Streamlined SBOM Fetching:

    • Earlier, the process involved two steps:
      • FindSBOMs collected metadata (e.g., name, size, download URL).
      • downloadSBOMs fetched content using those URLs.
    • Now, FindSBOMs handles both metadata retrieval and content downloading in a single step, storing []SBOMData (content and metadata). This eliminates the separate downloadSBOMs step, simplifying the pipeline.

@viveksahu26 viveksahu26 changed the title [refractor]: decoupling sequential and parallel downloads [refractor]: decoupling sequential and parallel downloads while fetching SBOMs in github adapter Apr 15, 2025
@viveksahu26 viveksahu26 marked this pull request as ready for review April 27, 2025 11:44
@viveksahu26 viveksahu26 force-pushed the refractor/decoupling_sequential_parallel_github_adp_logic branch from e86510e to b783282 Compare May 6, 2025 15:57
@viveksahu26 viveksahu26 requested a review from riteshnoronha May 6, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant