Add y/n for ignoring changes during deploy + show git diff #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great change, ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature; make the deploy script easier to use by (1) showing the
git diffwhen there are changes on prod, and (2) offering the deploy-runner the option to ignore the changes in-line.This also fixes a subtle bug, where you could add
IGNORE_CHANGES=1after seeing errors on one node, but not realize that you're also blowing away changes on other nodes that haven't been displayed yet!Technical
Testing
Tested on this latest deploy.
Screenshot
Stakeholders