Skip to content

add typehints to wikidata, reading goals, and waitinglist #10999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

add typehints to wikidata, reading goals, and waitinglist #10999

wants to merge 10 commits into from

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Jul 7, 2025 •
edited
Loading

  • disallow untyped definitions in wikidata
  • add typehints to yearly reading goals
  • add types to waitinglist.py

Closes #

Technical

Testing

Screenshot

Stakeholders

@RayBB RayBB changed the title wikidata types add typehints to wikidata, reading goals, and waitinglist Jul 7, 2025
@RayBB RayBB marked this pull request as draft July 7, 2025 20:37
@github-project-automation github-project-automation bot moved this to Waiting Review/Merge from Staff in Ray's Project Jul 7, 2025
@RayBB RayBB marked this pull request as ready for review July 8, 2025 03:58
RayBB
RayBB commented Jul 8, 2025
View reviewed changes
cdrini
cdrini reviewed Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice! A few fix ups. Also love moving towards a spot where we could enable some of the type checks for all the code.

@RayBB RayBB requested a review from cdrini July 25, 2025 05:59
cdrini
cdrini requested changes Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excepting two similar fixes to raise an error, and a rebase, lgtm!

@RayBB RayBB requested a review from cdrini August 1, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini Awaiting requested review from cdrini

Requested changes must be addressed to merge this pull request.

Assignees

@cdrini cdrini

Labels
None yet
Projects
Ray's Project
Status: Waiting Review/Merge from Staff
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RayBB @cdrini