unbreak my books for deleted books #11027
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
added
the
Patch Deployed
github-actions
bot
added
the
Priority: 1
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the "My Books" reading log page would crash when books referenced in the reading log had been deleted. Instead of asserting that all reading log items exist in Solr, it now gracefully handles missing books by logging warnings.
Key changes:
- Replaces a hard assertion with a conditional check for missing books
- Adds logging to track which books are missing from Solr
- Prevents page crashes when deleted books are referenced in reading logs
openlibrary/core/bookshelves.py
Outdated
| "see add_storage_items_for_redirects()" | ||
| ) | ||
| if len(solr_docs) <= len(reading_log_keys): | ||
| missing = set(w for w, e in reading_log_keys) - set([doc['key'] for doc in solr_docs]) |
There was a problem hiding this comment.
Use set comprehension instead of list comprehension wrapped in set(). Change set([doc['key'] for doc in solr_docs]) to {doc['key'] for doc in solr_docs} for better performance.
Suggested change
| missing = set(w for w, e in reading_log_keys) - set([doc['key'] for doc in solr_docs]) | |
| missing = set(w for w, e in reading_log_keys) - {doc['key'] for doc in solr_docs} |
Copilot uses AI. Check for mistakes.
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10970
Technical
My Books reading log pages breaks when books deleted; a deletion should probably cascade and remove related books from reading log table (similar to how we update redirects). In the interim, this solution should unbreak book pages by changing the
assertionto anifcheck.Testing
Tested on testing.
Screenshot
Stakeholders