Add support for extracting authentication params from www-authenticate header#237
Merged
JonasKs merged 2 commits intointility:mainfrom Mar 18, 2025
Merged
Add support for extracting authentication params from www-authenticate header#237JonasKs merged 2 commits intointility:mainfrom
JonasKs merged 2 commits intointility:mainfrom
Conversation
Contributor
|
LGTM, although I would prefer also to assert for the header value in other tests as well (i.e. when there is no authorization_url). |
Contributor
Author
|
Thanks for reviewing. Fair ask for the other tests. I've added a header validation for the 401 responses. |
Contributor
|
LGTM 👍 |
Contributor
Author
|
Anything more required before this can be merged? |
Member
|
No, I'll get to it this weekend |
Member
|
Thank you so much!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When receiving a request with
Authorization: Bearer, return an http 401 error with a header containing the necessary information to authenticate (WWW-Authenticate: Bearer, authorization_uri="https://...", client_id="...").This allows client like Excel to authenticate using organization credentials.
See documentation here and here.
Added a unit test in
test_single_tenant.pyto cover this scenario.Implementation of #232