-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade octokit dependencies #2459
base: main
Are you sure you want to change the base?
Conversation
Update: I seem to have finally found a combination of the Unfortunately I still have to add a
|
Would love to see this get in! |
@restfulhead I would be great to merge this in :) Hope the related PR helped a bit, but still seems some tests are failing. |
@restfulhead please rebase your branch on main and the failing tests should turn green. Is there anything else missing to get this merged? Have a great day. |
The main goal here is to upgrade `@octokit/plugin-throttling` to `5`, so that the secondary rate limit wait time is increased, wich hopefully fixes intuit#2458. This required other dependencies to be upgraded. The `resolutions` for `@octokit/plugin-rest-endpoint-methods` is necessary, because without it it pulls in `10.0.0` of `@octokit/types` which isn't compatible with the other libraries.
Finally found a combination of @octokit versions that all use @octokit/types 9.x
@LittleGreenYoda42 @dpotyralski Thanks, the rebase is done and the test build is now green. 🙌
In general, it would probably be a good idea for someone else to manually test this change. Also note that I haven't tested any plugins and I'm not sure how isolated they are from the dependency changes here. I checked |
Thanks @restfulhead for your input. I'm not sure if we are in a position to decide about the version here. Maybe @hipstersmoothie could add his opinion? |
Btw, if anyone would like to help test, I've released a beta version here: https://www.npmjs.com/package/@restfulhead/auto |
We still experience rate limiting errors here and there that prevent our workflows from properly executing, having up to date rate limiting/throttling plugins for Octokit would fix that. What can we do to help this PR get merged ? |
The main goal here is to upgrade
@octokit/plugin-throttling
to5
, so that the secondary rate limit wait time is increased, wich hopefully fixes #2458.This required other dependencies to be upgraded. The
resolutions
for@octokit/plugin-rest-endpoint-methods
is necessary, because without it, it pulls in10.0.0
of@octokit/types
which isn't compatible with the other libraries.Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major