gh-actions: fix workflow syntax #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
diegodelemos
commented
Dec 10, 2020
diegodelemos
commented
- Closes gh-actions: wrong workflow syntax #269.
diegodelemos
force-pushed
the
gh-fix-syntax-error
branch
from
3504e2e to
b7e9c0a
Compare
ParthS007
reviewed
Dec 10, 2020
.github/workflows/tests.yml
Outdated
| - search-service: es7 | ||
| db-service: mysql8 | ||
| COOKIECUTTER_DATAMODEL: None | ||
| - search-service: elasticsearch6 |
There was a problem hiding this comment.
Major:
Suggested change
| - search-service: elasticsearch6 | |
| - es-service: elasticsearch6 |
diegodelemos
force-pushed
the
gh-fix-syntax-error
branch
4 times, most recently
from
75ab411 to
27776dd
Compare
.github/workflows/tests.yml
Outdated
| docker --version | ||
| docker-compose --version | ||
| if [ ${E2E} == 'yes' ] && [ ! -f $HOME/webdrivers/chromedriver ]; then wget https://chromedriver.storage.googleapis.com/2.31/chromedriver_linux64.zip -P $HOME/webdrivers; unzip -d $HOME/webdrivers $HOME/webdrivers/chromedriver_linux64.zip; fi | ||
| nvm install 14.0.0; nvm use 14.0.0 |
There was a problem hiding this comment.
Maybe you can use something like setup-node action instead (untested)?
diegodelemos
force-pushed
the
gh-fix-syntax-error
branch
5 times, most recently
from
e7ac79a to
d13b3f8
Compare
diegodelemos
force-pushed
the
gh-fix-syntax-error
branch
from
d13b3f8 to
255a6fa
Compare
ParthS007
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.