navbar: add cog menu #2471
navbar: add cog menu #2471
Conversation
jrcastro2
commented
Oct 4, 2023
•
jrcastro2
commented
- closes https://github.com/zenodo/rdm-project/issues/262
jrcastro2
force-pushed
the
add-cog-menu
branch
3 times, most recently
from
38554c8 to
0d1aeab
Compare
invenio_app_rdm/theme/views.py
Outdated
| "administration.users", | ||
| _("Manage user"), | ||
| order=2, | ||
| endpoint_arguments_constructor=lambda: {"q": f"id:{current_user.id}"}, |
There was a problem hiding this comment.
Comment for reviewers, in the issue is specified to use the email. However if the preferences of the visibility are not set to public we cannot find the user by using the email, therefore I added the id that will always find the user (when searching as admin)
There was a problem hiding this comment.
I remember if you are user manager (role) you are supposed to be able to access the email field regardless if the email is visible or not (that is why in the admins search we can see all the users' emails - to be verified).
There was a problem hiding this comment.
We can see all the users in the admin page but we cannot search by email unless they have set the Profile visibility to Public.
List all users
Search for user with Public profile
Search for user with hidden profile
There was a problem hiding this comment.
Nice finding! thanks for checking this.
in this case I think we are just missing User manager generator (or permission?) in a right place for searching emails:
I think it is better to handle it by permissions rather than trying to circumvent it via ID. maybe makes sense to discuss during the standup?
There was a problem hiding this comment.
The email is not indexed if the user profile is set to hidden, therefore no one can search for it as it's not available, agreed over chat that we will use the username instead, which unique and indexed all the time and only admins can search for it.
jrcastro2
force-pushed
the
add-cog-menu
branch
2 times, most recently
from
72f6110 to
f103548
Compare
| @@ -126,6 +126,7 @@ def record_detail( | |||
| pid_value, record, files, media_files, is_preview=False, include_deleted=False | |||
| ): | |||
| """Record detail page (aka landing page).""" | |||
| record_owner = current_rdm_records.records_service.get_owner(pid_value) | |||
There was a problem hiding this comment.
Comment for reviewers:This returns the User model object which has no dict representation. As I commented here, maybe we should consider creating an interface for the owner as it could potentially be something different than a user.
There was a problem hiding this comment.
record is already resolved here, can't we resolve the owner directly?
jrcastro2
force-pushed
the
add-cog-menu
branch
from
f103548 to
405a114
Compare
| const handleError = (errorMessage) => { | ||
| console.error(errorMessage); | ||
| this.setState({ error: errorMessage }); | ||
| }; | ||
|
|
||
| return ( | ||
| <Grid columns={1} className="record-management"> | ||
| {permissions.can_edit && !isDraft && ( | ||
| {permissions.can_manage && ( |
There was a problem hiding this comment.
shouldn't be this can_moderate? Are we exposing the manage button to record owners/curators ?
zzacharo
force-pushed
the
add-cog-menu
branch
3 times, most recently
from
3e80c8b to
3edbd0e
Compare
zzacharo
force-pushed
the
add-cog-menu
branch
from
3edbd0e to
cf8f668
Compare
