Skip to content

templates: separate record detail content #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmorrell
Copy link
Contributor

@tmorrell tmorrell commented Jan 11, 2025

❤️ Thank you for your contribution!

Description

This PR splits the record detail template into the page template and a new template for the actual record content. This makes the template cleaner and more reusable, and is in preparation for being able to enhance the landing page in #2953

This PR does not make any changes to the templates, just splits the content into two.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Mar 12, 2025
@ntarocco ntarocco added this to v13.0.0 Mar 26, 2025
@ntarocco ntarocco moved this to Triage in v13.0.0 Mar 26, 2025
@utnapischtim utnapischtim moved this from Triage to 👀 In review in v13.0.0 May 21, 2025
<div class="ui container">
<div class="ui relaxed grid mt-5">
<div class="two column row top-padded">
{% include "invenio_app_rdm/records/record_content.html" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the idea to make record_content.html overridable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say embeddable instead of overridable. If you take a look at #2953, having the record content be separate would facilitate a tabbed interface for the landing page. There is probably more discussion needed on the specific interface....but I think this template change makes the templates more flexible in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity for more than 60 days.
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants