Skip to content

add internationalized page creation when creation is forced. #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

wgresshoff
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Use the new internationalization feature of invenio-pages add initialization time: create pages in every language supported by the instance.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@wgresshoff
Copy link
Contributor Author

wgresshoff commented Jan 22, 2025

Depends on inveniosoftware/invenio-pages#98 so tests will fail!

Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, requires a bump in setup.cfg to >=6.0.0,<7.0.0

@slint slint moved this from Triage to To Release in v13.0.0 Mar 26, 2025
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️⚠️

Good to release, as a "major" bump (i.e. bumping the bX part of the tag)

⚠️⚠️

Copy link
Contributor

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label May 26, 2025
@Samk13 Samk13 removed the stale No activity for more than 60 days. label May 26, 2025
@tmorrell
Copy link
Contributor

tmorrell commented Jun 3, 2025

@wgresshoff could you rebase this one?

@tmorrell tmorrell moved this from To release 🤖 to 🏗 In progress in v13.0.0 Jun 3, 2025
@wgresshoff wgresshoff force-pushed the add_i18n_to_pages branch from eb52c81 to 10a66bb Compare June 4, 2025 06:51
@wgresshoff
Copy link
Contributor Author

wgresshoff commented Jun 4, 2025

@tmorrell I did, but there are still problems (dependency resolution fails because invenio-collections and invenio-banner require different versions from invenio-administration).

@wgresshoff wgresshoff force-pushed the add_i18n_to_pages branch from 10a66bb to a2ddc76 Compare June 4, 2025 08:20
@tmorrell
Copy link
Contributor

tmorrell commented Jun 4, 2025

@utnapischtim will combine this PR with the other dependency bumps in #3050

@tmorrell
Copy link
Contributor

tmorrell commented Jun 4, 2025

Merged with #3050

@tmorrell tmorrell closed this Jun 4, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to To release 🤖 in v13.0.0 Jun 4, 2025
@tmorrell tmorrell moved this from To release 🤖 to Done ✔️ in v13.0.0 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

5 participants