-
Notifications
You must be signed in to change notification settings - Fork 157
add internationalized page creation when creation is forced. #2967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Depends on inveniosoftware/invenio-pages#98 so tests will fail! |
75c3521
to
9f4b681
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, requires a bump in setup.cfg
to >=6.0.0,<7.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ ⚠️
Good to release, as a "major" bump (i.e. bumping the bX
part of the tag)
⚠️ ⚠️
This PR was automatically marked as stale. |
@wgresshoff could you rebase this one? |
eb52c81
to
10a66bb
Compare
@tmorrell I did, but there are still problems (dependency resolution fails because invenio-collections and invenio-banner require different versions from invenio-administration). |
10a66bb
to
a2ddc76
Compare
@utnapischtim will combine this PR with the other dependency bumps in #3050 |
Merged with #3050 |
❤️ Thank you for your contribution!
Description
Use the new internationalization feature of invenio-pages add initialization time: create pages in every language supported by the instance.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: