Skip to content

fix(deposits): update doi default option only if managed #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sakshamarora1
Copy link
Contributor

fixes: CERNDocumentServer/cds-rdm#523

If the DOI is set as not required in the config and the record is published with 'No, I don't need one' selected, editing of that record will not change the DOI checkbox option. It should only update it to 'No, I need one' when the record already has a DOI.

if set(optional_doi_transitions["allowed_providers"]) - set(
["external", "not_needed"]
if (
"external" not in optional_doi_transitions["allowed_providers"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"external" not in optional_doi_transitions["allowed_providers"]
if all(provider not in optional_doi_transitions["allowed_providers"] for provider in ("external", "not_needed")):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposit: ensure DOI is minted when the option "No I need one" is selected
2 participants