ext: add celery signals ep #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcastro2
commented
Mar 26, 2025
jrcastro2
commented
- closes Job report invenio-jobs#67
jrcastro2
force-pushed
the
add-celery-signales-ep
branch
from
623c886 to
0d43f63
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for registering Celery signals via entry points, addressing the referenced issue.
- Introduces a new method load_celery_signals, which imports modules for signal registration
- Modifies init_app to set the logger level to DEBUG and load the signals
| @@ -34,10 +34,18 @@ def __init__(self, app=None, **kwargs): | |||
| def init_app(self, app, entry_point_group="invenio_celery.tasks", **kwargs): | |||
| """Initialize application object.""" | |||
| self.init_config(app) | |||
| app.logger.setLevel("DEBUG") | |||
There was a problem hiding this comment.
[nitpick] Setting the logger level to DEBUG directly here might override the application's logging configuration unexpectedly. Consider conditionally setting the logging level for development or making this configurable.
Suggested change
| app.logger.setLevel("DEBUG") | |
| log_level = app.config.get("LOG_LEVEL", "WARNING") | |
| app.logger.setLevel(log_level) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
jrcastro2
commented
Mar 27, 2025
| def load_celery_signals(self): | ||
| """Load Celery signals.""" | ||
| # Import Celery signals via entry points | ||
| for ep in pkg_resources.iter_entry_points("invenio_celery.signals"): |
There was a problem hiding this comment.
I addded this to have a common place where the signals are registered, it could also be done in each repo if we prefer - instead of using an entry point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.