fix datetime fields handling #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
commented
Jul 7, 2025
| @@ -247,13 +254,20 @@ class Meta: | |||
| def wrap_args(self, obj, many, **kwargs): | |||
| """Workaround for nested args.""" | |||
| # it is possible job has no arguments, that's why we use .get | |||
| obj["args"] = {"args": obj.get("args", {})} | |||
| obj["args"] = obj.get("args", {}) | |||
There was a problem hiding this comment.
@kpsherva any memory on what we were trying to fix here with the nested obj?
Maybe passing custom args was not working correctly?
There was a problem hiding this comment.
there is a problem with the structure when we serialize the arguments from the db, using the marshmallow schema. In one of the "load" or "dump" there is an additional level of args added, but I don't remember really why this is happening. I would try to remove it and see how it fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft, and requires more ❤️.
How to go about this:
sinceparam should stay a Python datetime obj all the time, and converted to str (JSON) only at the resource layer.