Fix-js-linting-errors #90

Samk13 · 2025-07-08T13:50:36Z

❤️ Thank you for your contribution!

Description

Enable js tests
Fix linting errors and warnings
Fix potential memory leak in RunsLogs
Other small fixes

Please test thoroughly, as I wasn’t able to run the full job in my dev environment.

Errors that is being fixed:

➜ ./run-js-linter.sh   
Run eslint
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.

/Users/test/invenio-jobs/invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/JobRunsHeader.js
   11:10  error  Insert `,`                                                   prettier/prettier
   25:7   error  Unused state field: 'title'                                  react/no-unused-state
   26:7   error  Unused state field: 'description'                            react/no-unused-state
   27:7   error  Unused state field: 'config'                                 react/no-unused-state
   28:7   error  Unused state field: 'loading'                                react/no-unused-state
   45:13  error  'data' is missing in props validation                        react/prop-types
   47:30  error  'data.links' is missing in props validation                  react/prop-types
   47:36  error  'data.links.self_admin_html' is missing in props validation  react/prop-types
   49:5   error  Delete `⏎`                                                   prettier/prettier
   54:7   error  'actions' is missing in props validation                     react/prop-types
   55:7   error  'apiEndpoint' is missing in props validation                 react/prop-types
   56:7   error  'idKeyPath' is missing in props validation                   react/prop-types
   57:7   error  'listUIEndpoint' is missing in props validation              react/prop-types
   58:7   error  'resourceName' is missing in props validation                react/prop-types
   59:7   error  'displayDelete' is missing in props validation               react/prop-types
   60:7   error  'displayEdit' is missing in props validation                 react/prop-types
   61:7   error  'data' is missing in props validation                        react/prop-types
   62:7   error  'error' is missing in props validation                       react/prop-types
   63:7   error  'loading' is missing in props validation                     react/prop-types
   69:29  error  'error.response' is missing in props validation              react/prop-types
   69:38  error  'error.response.status' is missing in props validation       react/prop-types
   70:32  error  'error.response' is missing in props validation              react/prop-types
   70:41  error  'error.response.data' is missing in props validation         react/prop-types
   75:40  error  'data.title' is missing in props validation                  react/prop-types
   76:42  error  'data.description' is missing in props validation            react/prop-types
   85:34  error  'data.title' is missing in props validation                  react/prop-types
  113:3   error  'jobId' PropType is defined but prop is never used           react/no-unused-prop-types

/Users/test/invenio-jobs/invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/RunActionForm.js
   50:7   error  'loading' is missing in props validation          react/prop-types
   51:7   error  'formData' is missing in props validation         react/prop-types
   52:7   error  'error' is missing in props validation            react/prop-types
   61:17  error  Identifier 'actions_errors' is not in camel case  camelcase
   61:47  error  Insert `;`                                        prettier/prettier
  156:25  error  Identifier 'actions_errors' is not in camel case  camelcase
  158:35  error  'error.content' is missing in props validation    react/prop-types
  172:57  error  Insert `⏎···················`                     prettier/prettier

/Users/test/invenio-jobs/invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/RunsLogs.js
    3:9   error    Replace `·Label,·Container,·Divider,·Grid,·Header,·Icon,·List,·Message,·Segment·` with `⏎··Label,⏎··Container,⏎··Divider,⏎··Grid,⏎··Header,⏎··Icon,⏎··List,⏎··Message,⏎··Segment,⏎`                                               prettier/prettier
    5:22  warning  'ErrorMessage' is defined but never used                                                                                                                                                                                          no-unused-vars
   13:13  warning  Must use destructuring props assignment                                                                                                                                                                                           react/destructuring-assignment
   15:71  error    Replace `"yyyy-MM-dd·HH:mm"` with `⏎··········"yyyy-MM-dd·HH:mm"⏎········`                                                                                                                                                        prettier/prettier
   17:12  warning  Must use destructuring props assignment                                                                                                                                                                                           react/destructuring-assignment
   18:13  warning  Must use destructuring props assignment                                                                                                                                                                                           react/destructuring-assignment
   24:3   warning  fetchLogs should be placed after componentWillUnmount                                                                                                                                                                             react/sort-comp
   26:45  error    Replace `.map((value)·=>·`search_after=${value}`)` with `⏎········.map((value)·=>·`search_after=${value}`)⏎········`                                                                                                              prettier/prettier
   37:71  error    Replace `"yyyy-MM-dd·HH:mm"` with `⏎··········"yyyy-MM-dd·HH:mm"⏎········`                                                                                                                                                        prettier/prettier
   56:27  error    Replace `⏎······?·DateTime.fromISO(finishedAt)⏎·····` with `·?·DateTime.fromISO(finishedAt)`                                                                                                                                      prettier/prettier
   82:13  error    Identifier 'formatted_started_at' is not in camel case                                                                                                                                                                            camelcase
   83:53  error    Replace `run.started_at,·run.finished_at` with `⏎········run.started_at,⏎········run.finished_at⏎······`                                                                                                                          prettier/prettier
   84:22  error    Replace `·run:·run,·runDuration:·runDuration,·formatted_started_at:·formatted_started_at` with `⏎········run:·run,⏎········runDuration:·runDuration,⏎········formatted_started_at:·formatted_started_at,⏎·····`                   prettier/prettier
   85:11  error    Replace `run.status·===·"SUCCESS"·||·run.status·===·"FAILED"·||·run.status·===·"PARTIAL_SUCCESS"` with `⏎········run.status·===·"SUCCESS"·||⏎········run.status·===·"FAILED"·||⏎········run.status·===·"PARTIAL_SUCCESS"⏎······`  prettier/prettier
   96:11  error    Identifier 'formatted_started_at' is not in camel case                                                                                                                                                                            camelcase
   97:51  error    Replace `run.started_at,·run.finished_at` with `⏎······run.started_at,⏎······run.finished_at⏎····`                                                                                                                                prettier/prettier
   98:5   error    Do not use setState in componentDidMount                                                                                                                                                                                          react/no-did-mount-set-state
   98:20  error    Replace `·runDuration:·runDuration,·formatted_started_at:·formatted_started_at` with `⏎······runDuration:·runDuration,⏎······formatted_started_at:·formatted_started_at,⏎···`                                                     prettier/prettier
  141:29  error    Replace `The·job·has·not·produced·any·logs·yet.` with `⏎················The·job·has·not·produced·any·logs·yet.⏎··············`                                                                                                    prettier/prettier
  142:29  error    Replace `Logs·were·deleted·due·to·the·retention·policy.` with `⏎················Logs·were·deleted·due·to·the·retention·policy.⏎··············`                                                                                    prettier/prettier
  168:26  error    Identifier 'formatted_started_at' is not in camel case                                                                                                                                                                            camelcase
  171:40  error    Identifier 'formatted_started_at' is not in camel case                                                                                                                                                                            camelcase
  190:27  error    Replace `·key={index}·className={`log-line·${log.level.toLowerCase()}`}` with `⏎························key={index}⏎························className={`log-line·${log.level.toLowerCase()}`}⏎······················`             prettier/prettier
  190:33  warning  Do not use Array index in keys                                                                                                                                                                                                    react/no-array-index-key
  191:57  error    Replace `[{log.formatted_timestamp}]` with `⏎··························[{log.formatted_timestamp}]⏎························`                                                                                                      prettier/prettier
  192:74  error    Replace `{log.level}` with `⏎··························{log.level}⏎························`                                                                                                                                      prettier/prettier

/Users/test/invenio-jobs/invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/RunsLogsView.js
   7:8   warning  '_get' is defined but never used                                                                              no-unused-vars
  20:14  error    Replace `⏎······logs={logs}⏎······run={run}⏎······sort={sort}⏎···` with `·logs={logs}·run={run}·sort={sort}`  prettier/prettier

/Users/test/invenio-jobs/invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/RunsSearchResultItemLayout.js
  102:34  warning  Do not use Array index in keys  react/no-array-index-key

✖ 64 problems (56 errors, 8 warnings)
  20 errors and 0 warnings potentially fixable with the `--fix` option.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

I'm aware of the code of conduct.
I've created logical separate commits and followed the commit message format.
I've added relevant test cases.
I've added relevant documentation.
I've marked translation strings.
I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
I've NOT included third-party code (copy/pasted source code or new dependencies).
- If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect on Discord.

Frontend

I've followed the CSS/JS and React guidelines.
I've followed the web accessibility guidelines.
I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

utnapischtim · 2025-07-09T07:20:53Z

invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/JobRunsHeader.js

@@ -18,17 +19,6 @@ import { Divider, Button, Grid, Header } from "semantic-ui-react";
 import { AdminUIRoutes } from "@js/invenio_administration";

 export class JobRunsHeader extends Component {
-  constructor(props) {


question: why has this been removed?

The constructor was removed because title, description, config and loading are now passed as props instead of managed in local state. The component no longer mutates them internally, so keeping a state copy was redundant.

but where are they passed as props, i couldn't find that in the diff

The props are passed via the data object see: here (containing title and description) and the direct loading prop.
So the parent component now manages these values instead of local state.

<JobRunsHeader data={{ title: "My Job Title", // Fills data.title description: "Job description", // Fills data.description links: { /*...*/ } }} loading={false} // Direct loading prop /* other props... */ />

utnapischtim · 2025-07-09T07:22:05Z

invenio_jobs/assets/semantic-ui/js/invenio_jobs/administration/RunsLogs.js

-              <Message.Item>The job has not produced any logs yet.</Message.Item>
-              <Message.Item>Logs were deleted due to the retention policy.</Message.Item>
+              <Message.Item>
+                The job has not produced any logs yet.


question: should this be marked as translatable?

I fixed these in another PR: #93

- Added JS job to the CI workflow for testing JavaScript files. - add node_modules to gitignore

- Removed unused constructor and state initialization. - Updated propTypes and defaultProps for clarity. - Added missing import for Actions.

the following is being fixed: * error 'loading' is missing in props validation * error 'formData' is missing in props validation * error 'error' is missing in props validation * error Identifier 'actions_errors' is not in camel case camelcase * error Identifier 'actions_errors' is not in camel case camelcase * error 'error.content' is missing in props validation

* Fix memory leak by properly canceling requests on unmount * Initialize derived state in constructor * Add log deduplication using timestamp-level-message keys * Use separate cancel tokens for different requests * Replace array index keys with stable composite keys * fix linter errors and warnings

* fix linting warning

* Using invenio_base.utils.entry_points for entry_points

Samk13 moved this to To test in v13.0.0 Jul 8, 2025

Samk13 added this to v13.0.0 Jul 8, 2025

ntarocco approved these changes Jul 9, 2025

View reviewed changes

utnapischtim reviewed Jul 9, 2025

View reviewed changes

Samk13 added 7 commits July 9, 2025 09:30

ci: add JS testing workflow and update gitignore

a58c21d

- Added JS job to the CI workflow for testing JavaScript files. - add node_modules to gitignore

refactor: clean up JobRunsHeader component

1b5fbb3

- Removed unused constructor and state initialization. - Updated propTypes and defaultProps for clarity. - Added missing import for Actions.

fix: run auto linter

9e7c0e3

style: remove unused import

34719eb

fix: improve key generation for message lines

ccedd3b

* fix linting warning

Samk13 force-pushed the fix-js-linting-errors branch from 7c97d40 to ccedd3b Compare July 9, 2025 07:31

chores: replaced importlib_xyz with importlib

448a62c

* Using invenio_base.utils.entry_points for entry_points

Samk13 force-pushed the fix-js-linting-errors branch from 72d0404 to 448a62c Compare July 10, 2025 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix-js-linting-errors #90

Fix-js-linting-errors #90

Uh oh!

Samk13 commented Jul 8, 2025 •

edited

Loading

Uh oh!

utnapischtim Jul 9, 2025

Uh oh!

Samk13 Jul 9, 2025

Uh oh!

utnapischtim Jul 9, 2025

Uh oh!

Samk13 Jul 9, 2025 •

edited

Loading

Uh oh!

utnapischtim Jul 9, 2025

Uh oh!

Samk13 Jul 9, 2025

Uh oh!

Uh oh!

Fix-js-linting-errors #90

Are you sure you want to change the base?

Fix-js-linting-errors #90

Uh oh!

Conversation

Samk13 commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please test thoroughly, as I wasn’t able to run the full job in my dev environment.

Checklist

Uh oh!

utnapischtim Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

utnapischtim Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

utnapischtim Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Samk13 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Samk13 commented Jul 8, 2025 •

edited

Loading

Samk13 Jul 9, 2025 •

edited

Loading