Drop RDMRecordQuota.user_id unique constraint
#2037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-moser
changed the title
RDMRecordQuota.user_id unique constraint
max-moser
commented
May 8, 2025
max-moser
force-pushed
the
mm/record-quota
branch
2 times, most recently
from
e1f382f to
729730f
Compare
max-moser
commented
May 8, 2025
slint
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
LGTM and good to merge/release.
@utnapischtim in theory this would be a major bump. Installing this version wouldn't break anything though and it's just a matter of running the Alembic recipe to apply the fix. Thus I think it would be fine to just release a patch.
* this seems to have been a copy-paste error, or similar * previously it was only possible to create an `RDMRecordQuota` for a single record per user due to this constraint
* previously, the quota setting logic only ran as part of `Record.create()` which is executed by the service before any service components are run * since the ownership information is set in a dedicated service component, this caused the `get_files_quota()` function to never pick up the appropriate `RDMUserQuota` for new drafts * so now we set the quota in a service component as well, to be run after the `AccessComponent`
|
I've rebased and removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Discord, this unique constraint prevents the creation of
RDMRecordQuotas for several records per user and was likely just a copy-paste error from somewhere else.In the Zenodo DB, this constraint was dropped already.
This PR chases that change.
ℹ️ for convenience reasons, i've also added a fix for the user quota not being respected to this PR (which took over as primary discussion point)
Given that v13 is scheduled to come out in just a few days (around 90), we'll just keep it a v13-only feature and add this to the list of known issues in v12.
Edit: Documentation update is here: inveniosoftware/docs-invenio-rdm#763