-
Notifications
You must be signed in to change notification settings - Fork 19
Multipart upload support #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multipart upload support #34
Conversation
Connected pull requests: RFC 0072 |
fdde850
to
cee8f40
Compare
* Implementation of multipart upload, as described in RFC 0072 * See inveniosoftware/rfcs#91 Co-authored-by: Mirek Simek <[email protected]>
cee8f40
to
3b4ba12
Compare
Question: The warnings at ext.py: typos in |
Those typos corrections have been there for more like 6 years. I think it's high time to get rid of the warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! These look like a sensible improvement to the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look great to me.
Rationale: the API and dependencies of s3fs have changed in versions >0.5.0. We will need to upgrade eventually, but I'd prefer doing it in a dedicated PR. The problem surfaced with `uv` as it uses different version conflict resolution.
* due to changes in the creation of url it is necessary to set THEME_FRONTPAGE explicitly
All comments have been addressed. I'm planning on merging and releasing this tomorrow, unless someone yells. |
Description
This pull request provides an implementation of multipart upload from RFC 0072.
The new methods are used by code changes in invenio-records-resources PR
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: