Skip to content

fix administration dep #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

utnapischtim
Copy link
Contributor

@utnapischtim utnapischtim commented Aug 8, 2024

  • setup: remove unused dependency
  • ci: use reusable workflows

NOTE:

  • this fix should fix the problem with the newly introduced invenio-users-resource dependency in invenio-accounts
  • there exists now a circular dependency between invenio-users-resources and invenio-accounts

solutions:

  • one solution would be to move the newly added cli to invenio-users-resources but i am not sure if a cli should be in a '*-resources' package
  • the other solution would be to move the models which are used in users-resources to users-resources
  • the last solution would be to live with the circular dependency

@utnapischtim utnapischtim requested review from slint and zzacharo August 8, 2024 09:25
@utnapischtim utnapischtim deleted the fix-administration-dep branch November 5, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

1 participant