pagination: fix negative page numbers on empty query

[Samk13]

❤️ Thank you for your contribution!

Description

• closes Pagination Error When Using Search Function in Community Members Tab invenio-communities#1136

the original symptom is that the initial value in the Redux store starts at -1. Changing it resolves the problem, but I am concerned that other logic might rely on the init value, potentially causing other issues. Therefore, I limited my change to this component.

Before:

Screencast.from.2024-05-28.16.07.46.webm

After

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[fenekku]

What I was wondering here was why this behavior is not observed for empty searches over records or empty searches over communities (searching for communities). It's strange that only empty searches over members are affected. Doing the 1 / 25 check assumes static default values (i.e., what about size of 10 and so on) and masks reason for discrepancy.

After investigating, I figured it's because Members search doesn't reuse the initial page and size querystring arguments when making search queries like is the case for other searches (e.g., https://github.com/inveniosoftware/invenio-communities/blob/master/invenio_communities/assets/semantic-ui/js/invenio_communities/community/searchComponents/CommunitiesSearchBarElement.js#L17). Fixing that, fixes the issue and puts Members search on par with other searches. This PR: inveniosoftware/invenio-communities#1207 can supersede this one.

[Samk13]

Closing in favor of inveniosoftware/invenio-communities#1207