-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix for string form fields #10814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix for string form fields #10814
Conversation
SchrodingersGat
commented
Nov 13, 2025
- replace null values with empty strings
- Ensure that strings are not replaced with null values sometimes
- replace null values with empty strings
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
We have to carefully consider this change, I'm not really sure if this does not break something. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10814 +/- ##
=======================================
Coverage 88.04% 88.05%
=======================================
Files 1281 1281
Lines 57625 57628 +3
Branches 1997 1997
=======================================
+ Hits 50736 50742 +6
+ Misses 6392 6389 -3
Partials 497 497
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@wolflu05 I have added some extra checks here, it will only overwrite a null value if the serializer does not allow null values |
… into null-field-fix
