Skip to content

Conversation

@SchrodingersGat
Copy link
Member

  • replace null values with empty strings
  • Ensure that strings are not replaced with null values sometimes

- replace null values with empty strings
@SchrodingersGat SchrodingersGat added this to the 1.2.0 milestone Nov 13, 2025
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed backport Apply this label to a PR to enable auto-backport action User Interface Related to the frontend / User Interface backport-to-1.1.x labels Nov 13, 2025
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit cf5665c
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/691f039f22c9c300084efae3
😎 Deploy Preview https://deploy-preview-10814--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (no change from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@wolflu05
Copy link
Member

We have to carefully consider this change, I'm not really sure if this does not break something.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.05%. Comparing base (a76ec0a) to head (cf5665c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10814   +/-   ##
=======================================
  Coverage   88.04%   88.05%           
=======================================
  Files        1281     1281           
  Lines       57625    57628    +3     
  Branches     1997     1997           
=======================================
+ Hits        50736    50742    +6     
+ Misses       6392     6389    -3     
  Partials      497      497           
Flag Coverage Δ
backend 89.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 92.00% <ø> (ø)
Backend General 93.79% <ø> (ø)
Frontend 70.39% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SchrodingersGat
Copy link
Member Author

@wolflu05 I have added some extra checks here, it will only overwrite a null value if the serializer does not allow null values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Apply this label to a PR to enable auto-backport action backport-to-1.1.x bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants