Skip to content

refactor(backend) rename barcode plugins #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Jun 23, 2025

Following development in #9761 and feedback in #9827 this renames the current barcode plugins.
Note: this only changes names on new instances of the plugin config.

The docs were already addressed in #9828

@matmair matmair added this to the 1.0.0 milestone Jun 23, 2025
@matmair matmair self-assigned this Jun 23, 2025
@matmair matmair requested a review from SchrodingersGat as a code owner June 23, 2025 18:36
@matmair matmair added plugin Plugin ecosystem refactor labels Jun 23, 2025
@matmair matmair marked this pull request as draft June 23, 2025 18:36
Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit ba61faf
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/6859ddd2ce2d6a0008440894

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (4d029b0) to head (ba61faf).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9829   +/-   ##
=======================================
  Coverage   86.56%   86.57%           
=======================================
  Files        1243     1243           
  Lines       54683    54687    +4     
  Branches     2230     2230           
=======================================
+ Hits        47337    47343    +6     
+ Misses       6780     6778    -2     
  Partials      566      566           
Flag Coverage Δ
backend 88.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matmair matmair marked this pull request as ready for review June 23, 2025 23:26
@30350n
Copy link
Contributor

30350n commented Jun 24, 2025

FYI, I choose the names like that back then to leave the option for these plugins to implement other supplier related functionality/interfaces ... so pretty much exactly what's being implemented in #9761 rn. I would generally be interesting in looking into implementing them for atleast some of the suppliers, so I'm unsure how much sense this change would make now.

@matmair
Copy link
Contributor Author

matmair commented Jun 24, 2025

It leads to confusion right now and the function is not there. We are gearing up for 1.0 so I’d like to get this sorted before

@SchrodingersGat
Copy link
Member

Won't renaming the slugs mean that any users who have this already "enabled" will find these plugins are now disabled on update?

@matmair
Copy link
Contributor Author

matmair commented Jun 24, 2025

These are the current slugs, they were added to ensure that settings etc stay consistent

@SchrodingersGat
Copy link
Member

@matmair ah, on a second read through I see the logic :)

@SchrodingersGat SchrodingersGat merged commit 3c2997e into inventree:master Jun 24, 2025
29 checks passed
@SchrodingersGat SchrodingersGat deleted the refactor(backend)--rename-barcode-plugins branch June 24, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Plugin ecosystem refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants