-
-
Notifications
You must be signed in to change notification settings - Fork 998
refactor(backend) rename barcode plugins #9829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend) rename barcode plugins #9829
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9829 +/- ##
=======================================
Coverage 86.56% 86.57%
=======================================
Files 1243 1243
Lines 54683 54687 +4
Branches 2230 2230
=======================================
+ Hits 47337 47343 +6
+ Misses 6780 6778 -2
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FYI, I choose the names like that back then to leave the option for these plugins to implement other supplier related functionality/interfaces ... so pretty much exactly what's being implemented in #9761 rn. I would generally be interesting in looking into implementing them for atleast some of the suppliers, so I'm unsure how much sense this change would make now. |
It leads to confusion right now and the function is not there. We are gearing up for 1.0 so I’d like to get this sorted before |
Won't renaming the slugs mean that any users who have this already "enabled" will find these plugins are now disabled on update? |
These are the current slugs, they were added to ensure that settings etc stay consistent |
@matmair ah, on a second read through I see the logic :) |
Following development in #9761 and feedback in #9827 this renames the current barcode plugins.
Note: this only changes names on new instances of the plugin config.
The docs were already addressed in #9828