-
Notifications
You must be signed in to change notification settings - Fork 69
Build Order #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Build Order #673
Conversation
I'll need some time to look over this more thoroughly but the implementation looks great on first glance! Very comprehensive :) |
|
||
return ListTile( | ||
title: Text(order.reference), | ||
subtitle: Text(order.description), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually "order.title" for the build order, not "description" - which is why no subtitle text is appearing here
SpeedDialChild( | ||
child: const Icon(TablerIcons.camera, color: Colors.blue), | ||
label: "Take Picture", // Will use L10().takePicture later | ||
onTap: () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to come back to these :)
@cbenhagen this looks really promising! LMK when you have it more feature complete and I will review again. Seems to work well on my setup |
if (widget.order.pk > 0) { | ||
// To be implemented later when build order is fully integrated | ||
// This will load all build order related data (attachments, outputs, etc.) | ||
refresh(context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this is currently causing an infinite loop...
The "right chevron" arrow you put into the tiles was a great idea - I'm rolling that out across all the views: |
Please feel free to push to this branch. I will not have much time to work on this in the upcoming weeks. |
I'm probably not going to be able to get to it for a while either :) |
This is a very rough draft of the build order feature.
fixes #287