Handle list returns from creating StockItems #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1337joe
changed the title
|
@1337joe thanks for submitting the fix here too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since inventree/InvenTree#9857 the
StockItemcreate API has been able to return multiple items for a single call. The python API was not updated to handle this (as tested by the first commit on this branch), which blocked my attempt at fixing the annotations to generate a usable API schema (inventree/InvenTree#9969).Breaking: This PR changes
StockItemcreate to always return a list of items.With these changes both
masterand inventree/InvenTree#9969 are able to pass the API tests.As always, let me know if anything needs to change to fit Python conventions/project style/etc.