Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resources property can be null in newer Firebase projects if no products have been enabled on the project #329

Merged
merged 12 commits into from
Jul 29, 2024
Merged

fix: resources property can be null in newer Firebase projects if no products have been enabled on the project #329

merged 12 commits into from
Jul 29, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 24, 2024 •
edited
Loading

Description

  1. Fixed resources so it defaults to empty object as confirmed by the user.
  2. Created global debugMode and logger which can be used in future issues to help debug issues.
  3. Removed duplicate getProjects() call here.
  4. Updated logic for getting firebase projects to write to file if JSON file is huge. For users that have more than 400 projects.

fixes #328

Type of Change

  • ✨ feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ❌ ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ✅ ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@russellwheatley russellwheatley changed the title add debug logging fix: resources property can be null in newer Firebase projects if no products have been enabled on the project Jul 29, 2024
@russellwheatley russellwheatley marked this pull request as ready for review July 29, 2024 10:44
@russellwheatley russellwheatley merged commit 67df625 into main Jul 29, 2024
10 of 11 checks passed
@russellwheatley russellwheatley deleted the temp-file-for-large-json branch July 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyokone Lyokone Lyokone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: flutterfire configure "type 'Null' is not a subtype of type 'Map<dynamic, dynamic>' in type cast"
2 participants
@russellwheatley @Lyokone