-
Notifications
You must be signed in to change notification settings - Fork 12
docs(pubsub.v2): restructure, simplify & expand on pubsub v2 component #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for invictus-for-azure ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pim-simons
reviewed
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only some small notes 👍🏻
On a sidenote, these documentation updates are absolutely amazing! 🥇 |
pim-simons
previously approved these changes
Jun 19, 2025
GoutsmitSam
previously approved these changes
Jun 20, 2025
776b213
pim-simons
previously approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PubSub v2 Framework component had both too much and too little information on its feature documentation page. It talks about certain internal decisions - which are of no use to users, and does not specify certain context/customization on other parts.
This PR tries to focus the page more on the user's perspective by providing a pseudo Logic App setup, customizable Bicep parameters, and a more clear API exposure of what the component provides.