Converge fork with main repo #34
Conversation
Conflicts: recipes/PHP_CodeSniffer.rb recipes/predis.rb
Inviqa origin master merged into unstable/MSGD to prepare PR
to be consistent with all the other recipes and defaults
Version bumped because of recent changes
There was a problem hiding this comment.
Are you sure we need to revert to an older version of the opscode php cookbook?
There was a problem hiding this comment.
That's part of the Missguided customisation unfortunately. We could make it cleaner and use our project based Cheffile to ensure the expected project dependency. Would that be better?
There was a problem hiding this comment.
Would that work as a solutions? This version of the chef-php-extra will depend on the php 1.1.8 cookbook, I don't think it will be possible to lock the cookbook to 1.1.0 with the Cheffile if one of the cookbooks requires a more recent version.
There was a problem hiding this comment.
We did the same yesterday with the dmg cookbooks while creating my VM if you remember
There was a problem hiding this comment.
In that case the cookbook that required the dependency was not specifying the version of the dependency. Because of that, librarian-chef update was downloading the latest version, but we could still lock it to any other version.
|
Other than the question about the dependency version this looks good! |
3 participants
No description provided.