feat: add standard host.docker.internal DNS on linux for console #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierenevans
reviewed
Mar 22, 2024
andytson-inviqa
force-pushed
the
feature/host-docker-internal
branch
from
d276cf7 to
9dc4b51
Compare
kierenevans
approved these changes
Mar 22, 2024
|
needs latest jenkins runner image (requires 24.0.3+ and 0.11.1+ buildx) |
|
not sure this is any good now as it uses the default docker bridge gateway, rather than the compose project's "private" network gateway that https://github.com/inviqa/harness-base-php/blob/2.0.x/src/_base/docker/image/console/root/entrypoint.sh.twig#L9 ends up with, so might not work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.