-
Notifications
You must be signed in to change notification settings - Fork 172
Update stateroles.md - add switch.feature #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add the role `switch.feature` do distinguish switching on / off a feature like "childlock" or "open window detection" from switching power or switching a mode. It could be useful in the future to add a generic "features" thingie in types. Loosely connected to this issue in type-detector ioBroker/ioBroker.type-detector#118 From a type-detector perspective the role `switch` should not be used at all.
@GermanBluefox can you have a look here? Or @Apollon77? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me ok. solves a problem
Why not |
Why not simply adjust the RegEX for POWER as stated in the description, namely exclusively |
I would suppose to use "switch.power" and "switch.mode" and adjust the type-detector, that will try first to find switch power and then just switch..... |
I checked. switch.mode alone is also not used. So we could also use this. And „a generic mode flag“ could have the same purpose than switch.feature. @J-Paul0815 for thermostat alone adjusting switch.power regex to not allow „switch“ in type detector is „just“ a backward compatibility topic. |
OK, then let's use switch.mode. |
I changed the PR: |
Please see the discussed counter proposal in https://github.com/ioBroker/ioBroker.docs/pull/607/files |
Add the role
switch.feature
do distinguish switching on / off a feature like "childlock" or "open window detection" from switching power or switching a mode.It could be useful in the future to add a generic "features" thingie in types.
Loosely connected to this issue in type-detector ioBroker/ioBroker.type-detector#118 From the type-detector perspective the role
switch
should not be used at all.