Skip to content

Add wbec to latest #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add wbec to latest #4824

wants to merge 1 commit into from

Conversation

jb-io
Copy link

@jb-io jb-io commented May 22, 2025

Please add my adapter ioBroker.wbec to latest.

Copy link

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

Important:

To verify the object structure of this adapter during REVIEW please export the object structure of a working installation and attach the file to this PR. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.
mcm1957

@simatec Please take a look in respect to responsive design. Thanks

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label May 22, 2025
Copy link

Automated adapter checker

ioBroker.wbec

Downloads Number of Installations (latest) - Test and Release
NPM

👍 No errors found

  • 👀 [W401] Cannot find "wbec" in latest repository

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented May 23, 2025

reminder 30.5.2025

@mcm1957 mcm1957 added REVIEW pending (by mcm1957) obj-json missing The reuqsted dump obj objects in json format is missing labels May 25, 2025
@jb-io
Copy link
Author

jb-io commented May 25, 2025

Here the missing obj-json

wbec.1.json

@github-actions github-actions bot added the *📬 a new comment has been added label May 25, 2025
@mcm1957 mcm1957 removed *📬 a new comment has been added obj-json missing The reuqsted dump obj objects in json format is missing labels May 25, 2025
@jb-io
Copy link
Author

jb-io commented May 25, 2025

Just released a new version with translated states:
wbec.0.json

@github-actions github-actions bot added the *📬 a new comment has been added label May 25, 2025
@jb-io
Copy link
Author

jb-io commented Jun 4, 2025

@mcm1957
Is there anything I still need to do for this pull request to be merged, or do I just need to be patient?
Sorry for the question — I just want to make sure I haven’t missed anything.

@mcm1957
Copy link
Collaborator

mcm1957 commented Jun 4, 2025

No - its totally my fault / problem / missing time.
Very very Sorry

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jun 4, 2025
@mcm1957
Copy link
Collaborator

mcm1957 commented Jun 4, 2025

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

SORRY FOR THE VERY LONG PROCESSING TIME

I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.

  • invalid email

    Please add an email address which allows you to connect. We cannot reach out to you using a "no-reply" github address in case some contact is required.

  • invalid characters should be filtered from object ids

    Some characters are not allowed to be used as part of an object id. If an object id is not hardcoded or even depending on user input you should ensure that such an object id does not contain an invalid character. Iobroker provides the constant adapter.FORBIDDEN_CHARS, i.e. by using the following snippet:

function name2id(pName) {
    return (pName || '').replace(adapter.FORBIDDEN_CHARS, '_');
}

ObjectIds seem to be based on response from wbed.cleint api which in return seems to read informatuon from wallbos / device. So this ids must be filtered using FORBIDDEN_CHARS at least. Best praxis is to limit ids to A-Za-z0-9_- but filteriung FORBIDDEN_CHARS is sufficient if you remove dot and spaces too.

  • reevaluate state roles and object types

    Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.

    In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully. States with role 'button' should (must) have attribute 'common.read=false' set. A button ( "Taster" in german only triggers when you press but else has no state), so it should also be not readable. This is also like HomeMatic does it. A switch has clear states true or false and so can be read.

    Please avoid using general roles (state, value) whnever a dedicated role exists.

    • Your 'directories' cgf, info, modbus ect. (except boxn) do not really correlate to some devide. So I would suggest to change the type to channel or folder
    • some states do not ahve a valid role assigned, i.e. box0.busid, cfg.*
    • indicators MUST be boolean
    • writeable states MUST NOT have a value role, use LEVEL in this case (i.e currLim)
  • check and limit configurable timeouts / intervals

    Node setTimeout/setInterval routines have a maximum allowed value of 2,147,483,647 ms. Using delays larger than 2,147,483,647 ms (about 24.8 days) result in the timeout being executed immediately. So all (user configurable) values passed to setTimeout / setInterval should be checked in code and limited. Checking/limiting in code is required as config data could be changed directly or by some other adapter too, so limiting at ui level might not be sufficient.

  • adapt testing to supported node releases

    Please add node.js 24 tests

    Tests for node 20 are mandatory as this is the recommended node version.
    Tests for node 22 are mandatory as this is the current LTS node version.
    Tests for node 24 are mandatory unless you already know incompatibilities which cannot be fixed immidiatly. In this case please create a issue stating the problem and fix as soon as possible.

    So the recommended testmatrix is [20.x, 22.x, 24.x] depending on engines requirments setting at package.json

    Tests must be performed at all supported platforms (linux, windows, mac) unless special hardware or software restrictions prohibit this.

Thanks for reading and evaluating this suggestions.
McM1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

Please add a new object export too*

reminder 18.6.2025

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review 30.5.2025 and removed 18.6.2025 labels Jun 4, 2025
@mcm1957
Copy link
Collaborator

mcm1957 commented Jun 18, 2025

@jb-io
Did you notice my review comments?

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 13, 2025

@jb-io
I've dropped some review comments at Jun 4. Please provide some feedback if you already processed / fixed those remarks so that a re-review should be started.

If you did not yet have time to review / process please let me know some timeframe when to expect this to be done.

Thanks

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 13, 2025

reminder 20.7.2025

@mcm1957 mcm1957 added stale PR seems has no activity, will be closed after some time 18.6.2025 and removed 20.7.2025 labels Jul 13, 2025
@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 21, 2025

@jb-io
I've dropped some review comments at Jun 4.

I hope you are well and there's no serious reason to do not respond anymore. So lease provide some feedback if you already processed / fixed those remarks so that a re-review should be started. If you did not yet have time to review / process please let me know some timeframe when to expect this to be done.

Thanks

If there is no reaction at all (not even some 'iI'll will process after x.y.z') until 21.8.2025 this PR will be closed.

reminder 4.8.2025

@github-actions github-actions bot added 4.8.2025 remind after 4.8.2025 and removed 20.7.2025 labels Jul 21, 2025
@mcm1957 mcm1957 added stale - marked for closing There was no feedback vom PR owner, PR will be closed. 20.7.2025 and removed stale PR seems has no activity, will be closed after some time 4.8.2025 remind after 4.8.2025 labels Jul 21, 2025
@github-actions github-actions bot added 4.8.2025 remind after 4.8.2025 and removed 20.7.2025 labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.8.2025 remind after 4.8.2025 auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review new at LATEST stale - marked for closing There was no feedback vom PR owner, PR will be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants