-
Notifications
You must be signed in to change notification settings - Fork 298
Add wbec to latest #4824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add wbec to latest #4824
Conversation
ioBroker repository information about New at LATEST taggingThanks for spending your time and providing a new adapter for ioBroker. Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases. In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:
Important: To verify the object structure of this adapter during REVIEW please export the object structure of a working installation and attach the file to this PR. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched. If you have any urgent questions feel free to ask. @simatec Please take a look in respect to responsive design. Thanks |
Automated adapter checkerioBroker.wbec👍 No errors found
Add comment "RE-CHECK!" to start check anew |
reminder 30.5.2025 |
Here the missing obj-json |
Just released a new version with translated states: |
@mcm1957 |
No - its totally my fault / problem / missing time. |
First of all - THANK YOU for the time and effort you spend to maintain this adapter. SORRY FOR THE VERY LONG PROCESSING TIME I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.
ObjectIds seem to be based on response from wbed.cleint api which in return seems to read informatuon from wallbos / device. So this ids must be filtered using FORBIDDEN_CHARS at least. Best praxis is to limit ids to A-Za-z0-9_- but filteriung FORBIDDEN_CHARS is sufficient if you remove dot and spaces too.
Thanks for reading and evaluating this suggestions. Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review! Please add a new object export too* reminder 18.6.2025 |
@jb-io |
@jb-io If you did not yet have time to review / process please let me know some timeframe when to expect this to be done. Thanks |
reminder 20.7.2025 |
@jb-io I hope you are well and there's no serious reason to do not respond anymore. So lease provide some feedback if you already processed / fixed those remarks so that a re-review should be started. If you did not yet have time to review / process please let me know some timeframe when to expect this to be done. Thanks If there is no reaction at all (not even some 'iI'll will process after x.y.z') until 21.8.2025 this PR will be closed. reminder 4.8.2025 |
Please add my adapter ioBroker.wbec to latest.