Skip to content

Add openmediavault to latest #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Scrounger
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jul 8, 2025

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

Important:

To verify the object structure of this adapter during REVIEW please export the object structure of a working installation and attach the file to this PR. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.
mcm1957

@simatec Please take a look in respect to responsive design. Thanks

@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Jul 8, 2025
@mcm1957 mcm1957 changed the title OpenMediaVault adapter added Add OpenMediaVault to latest Jul 8, 2025
@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 8, 2025

reminder 15.7.2025

@mcm1957 mcm1957 added the obj-json missing The reuqsted dump obj objects in json format is missing label Jul 8, 2025
@github-actions github-actions bot added the *📬 a new comment has been added label Jul 9, 2025
@github-actions github-actions bot deleted a comment from Scrounger Jul 9, 2025
@Scrounger
Copy link
Contributor Author

@mcm1957:
What's the meaning of the flag obj-json missing. Can't find any info's for that

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 9, 2025

please see comment above:

To verify the object structure of this adapter during REVIEW please export the object structure of a working installation and attach the file to this PR. You find a guide how to export the object struture here: https://github.com/ioBroker/ioBroker.repochecker/blob/master/OBJECTDUMP.md

@Scrounger
Copy link
Contributor Author

Scrounger commented Jul 9, 2025

@mcm1957

seriously?
The object structure can also contain sensitive data such as Mac addresses, serial numbers, uuid's, names of people, etc.

If you have several hundred objects in the adapter that contain such data, for example, it takes a lot of effort to make this data available in a clean form.

And the object structure can also look slightly different for everyone, e.g. if you process an api and do not own all devices

Sorry, this is too much effort for an OpenSource project

@mcm1957 mcm1957 added REVIEW pending (by mcm1957) and removed *📬 a new comment has been added labels Jul 13, 2025
@mcm1957 mcm1957 changed the title Add OpenMediaVault to latest Add openmediavault to latest Jul 13, 2025
Copy link

Automated adapter checker

ioBroker.openmediavault

Downloads - Test and Release
NPM

👍 No errors found

  • 👀 [W401] Cannot find "openmediavault" in latest repository

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 16, 2025

@mcm1957

seriously? The object structure can also contain sensitive data such as Mac addresses, serial numbers, uuid's, names of people, etc.

I would like to check the object structure created by the adapter especially hirarchy, roles, etc.
I understand your concerns about sensitive data. I would suggest to create an export WITHOUT state data. This should ensure that the structure is visible, but no sensitive content is exported.

image

reminder 23.7.2025

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review REVIEW pending (by mcm1957) labels Jul 16, 2025
@github-actions github-actions bot added 23.7.2025 remind after 23.7.2025 and removed 15.7.2025 labels Jul 16, 2025
@Scrounger
Copy link
Contributor Author

Scrounger commented Jul 17, 2025

This should ensure that the structure is visible, but no sensitive content is exported.

Excluding the states is not the solution, object structure it self can contain sensitive data (e.g. mac's in id).
The hierarchy is predefined according to the dev docs channel -> device -> channel. All roles are set to states.
More details can be found through code review.

Sorry but I don't have the time to do the effort to bring the structure into a clean form.
It is your decision whether the adapter should go into the repository or not.

@github-actions github-actions bot added the *📬 a new comment has been added label Jul 17, 2025
@mcm1957 mcm1957 added REVIEW pending (by mcm1957) and removed *📬 a new comment has been added labels Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23.7.2025 remind after 23.7.2025 auto-checked This PR was automatically checked for obvious criterias new at LATEST obj-json missing The reuqsted dump obj objects in json format is missing REVIEW pending (by mcm1957)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants