-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links #147
Fix links #147
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I'm very sorry for overlooking this, but it's most probably a tech debt (or what should I call it) carried forward from |
Not your fault. That is why we run tests ;-p Thanks for the working URL. I'll update it accordingly. |
I hope this is ready to merge? just mentioning @ocefpaf for you to merge it whenever it's ready. PS. Just to make sure we are not waiting for me. |
👍🏽
I was but NP. I try to avoid self-merges as much as I can. Thanks for the review and for the fix! |
Should help fix the link-checker failure in #146.
@ayushanand18 I'm not sure if you are the one that created the bit.ly link but can you try to help me sort this out?
The link seems to redirect to an
http
page that doesn't seem correct to me. Also, it is broken in #146. Last but not least, I'd rather have the full link and skip code style there than have the info obfuscated by a URL shortener.In this PR I added the full URL and the lint skips but I need some help to check if that URL is actually the one the authors of the docstrings added there originally.