Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #147

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Fix links #147

merged 4 commits into from
Apr 8, 2024

Conversation

ocefpaf
Copy link
Collaborator

@ocefpaf ocefpaf commented Apr 2, 2024

Should help fix the link-checker failure in #146.

@ayushanand18 I'm not sure if you are the one that created the bit.ly link but can you try to help me sort this out?
The link seems to redirect to an http page that doesn't seem correct to me. Also, it is broken in #146. Last but not least, I'd rather have the full link and skip code style there than have the info obfuscated by a URL shortener.

In this PR I added the full URL and the lint skips but I need some help to check if that URL is actually the one the authors of the docstrings added there originally.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

pyobis/dataset/dataset.py Outdated Show resolved Hide resolved
@ocefpaf ocefpaf marked this pull request as ready for review April 2, 2024 15:53
@ayushanand18
Copy link
Collaborator

I'm very sorry for overlooking this, but it's most probably a tech debt (or what should I call it) carried forward from pygbif -> pyobis when original authors copied configs while creating the latter.

pyobis/occurrences/occurrences.py Outdated Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Apr 4, 2024

I'm very sorry for overlooking this, but it's most probably a tech debt (or what should I call it) carried forward from pygbif -> pyobis when original authors copied configs while creating the latter.

Not your fault. That is why we run tests ;-p

Thanks for the working URL. I'll update it accordingly.

@ayushanand18
Copy link
Collaborator

ayushanand18 commented Apr 7, 2024

I hope this is ready to merge? just mentioning @ocefpaf for you to merge it whenever it's ready.

PS. Just to make sure we are not waiting for me.

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Apr 8, 2024

I hope this is ready to merge? just mentioning @ocefpaf for you to merge it whenever it's ready.

👍🏽

PS. Just to make sure we are not waiting for me.

I was but NP. I try to avoid self-merges as much as I can. Thanks for the review and for the fix!

@ocefpaf ocefpaf merged commit 6bd509c into iobis:main Apr 8, 2024
17 checks passed
@ocefpaf ocefpaf deleted the fix_links branch April 8, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants