-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS): KV, Context fixes #83
Conversation
🦋 Changeset detectedLatest commit: 7df7a60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry if this is not the ideal place for my notes; but i want you to know that with any version > 1.0.5 (e.g. 1.0.6-dev-20240409T144959.0 or 1.0.6-dev-20230915T160000.0) the CPU of the iOS-Device is always under pressure (high load) shortly after starting the app, even without dispatching any event. Maybe you can have a look at that, too? I am very excited for a new version :) |
Hello! I would open a new issue with a test app that reproduces the issue (and preferably screenshots from Instruments showing CPU load). If you have general questions, you can ping me in the Ionic Discord. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the updates to `throws, LGTM
This PR fixes various issues on the iOS Engine:
KV.get
on an non-existent key returned an empty object instead of null