-
Notifications
You must be signed in to change notification settings - Fork 41
chore(android,ios): update to Capacitor 8, android to API 36 and Gradle dependencies to latest #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
OS-ruimoreiramendes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some merge conflicts here, just a quick note.
@OS-ruimoreiramendes thank you for noting. Yes, another PR was merged this morning so that caused the conflicts. They should be simple to solve though. |
…/capacitor-barcode-scanner into chore/RMET-4678/up-gradle-dep
|
Note: CI is failing for android builds, unsure if it is because the plugin is not depending on Capacitor 8 yet, possibly if it's that, but if you'd like to double check @alexgerardojacinto |
@OS-pedrogustavobilro yeah I think it might be related to that, I'll have a look, thank you! |
|
This PR should remain open until we update the plugin to Capacitor 8 - in fact, those changes can be done in this PR. The reason being that this plugin isn't configured for next/alpha versions, so we only want to update to Capacitor 8 once we have a stable version we can use. |
Co-authored-by: Pedro Bilro <[email protected]>
…/capacitor-barcode-scanner into chore/RMET-4678/up-gradle-dep
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexgerardojacinto, missing updating the deployment target to iOS 15 for the plugin (both podspec and package.swift), believe that's why the CI is failing
|
@OS-pedrogustavobilro updated it now, thank you! |
8.0.0-beta.0(SHOULD BE UPDATED TO8.0.0stable before merging).podspecandPackage.swiftcompileSdkandtargetSdkto36.example-app.