fix(web): Close button not resolving promise#116
Merged
OS-ruimoreiramendes merged 6 commits intomainfrom Feb 6, 2026
Merged
Conversation
OS-pedrogustavobilro
approved these changes
Feb 6, 2026
Contributor
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Tested here, seems to be working fine now, nice!
OS-pedrogustavobilro
pushed a commit
that referenced
this pull request
Feb 11, 2026
Re-ran lint because of changes in linter between main and 2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in the Web implementation where cancelling the scanner via the close button left the scan promise unresolved.
Fixes #81