Skip to content

Conversation

@OS-pedrogustavobilro
Copy link
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro commented Sep 23, 2025

Note

CI is failing here, but gets fixed by #137

PR description

This PR contains the following fixes for the test app inside plugin/e2e-tests:

  1. 8a5c22f - Separate map id's for each map in each page of the app. The reason being is sometimes if you created and destroyed a map in a page, and then tried to create one in another page with the same id, it would cause the height computation to fail, and the map would not be visible. With separate id's for each map, this no longer occurs.
  2. 2e80f91 - Change map dimensions in some pages. The maps were cropping part of the buttons in some screens when testing on an iPhone SE, so adjusted some map heights for this not to be a problem.

@OS-pedrogustavobilro OS-pedrogustavobilro self-assigned this Sep 23, 2025
@OS-pedrogustavobilro OS-pedrogustavobilro marked this pull request as ready for review September 23, 2025 12:20
@OS-pedrogustavobilro OS-pedrogustavobilro requested a review from a team September 23, 2025 12:20
OS-pedrogustavobilro added a commit that referenced this pull request Sep 23, 2025
@OS-pedrogustavobilro OS-pedrogustavobilro merged commit 2f51efb into main Sep 23, 2025
7 checks passed
@OS-pedrogustavobilro OS-pedrogustavobilro deleted the chore/RMET-4220/app-minor-fixes branch September 23, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants