Skip to content

Fix iOS CLI checks and Cordova Package.swift generation race #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −6
Open

Fix iOS CLI checks and Cordova Package.swift generation race #8252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a32354a
Fix async Cordova package generation
Nov 21, 2025
9784c00
Merge branch 'main' into main
MOHITKOURAV01 Nov 25, 2025
1202888
Merge branch 'main' into main
MOHITKOURAV01 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/src/ios/doctor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export async function doctorIOS(config: Config): Promise<void> {
// check online datebase of common errors
// check if www folder is empty (index.html does not exist)
try {
await check([() => checkBundler(config) || checkCocoaPods(config), () => checkWebDir(config), checkXcode]);
await check([() => checkBundler(config), () => checkCocoaPods(config), () => checkWebDir(config), checkXcode]);
logSuccess('iOS looking great! 👌');
} catch (e: any) {
fatal(e.stack ?? e);
Expand Down
8 changes: 5 additions & 3 deletions cli/src/ios/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,11 @@ async function updatePluginFiles(config: Config, plugins: Plugin[], deployment:
}

async function generateCordovaPackageFiles(cordovaPlugins: Plugin[], config: Config) {
cordovaPlugins.map((plugin: any) => {
generateCordovaPackageFile(plugin, config);
});
await Promise.all(
cordovaPlugins.map(async (plugin) => {
await generateCordovaPackageFile(plugin, config);
}),
);
}

async function generateCordovaPackageFile(p: Plugin, config: Config) {
Expand Down
2 changes: 1 addition & 1 deletion cli/src/tasks/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function printNextSteps(platformName: string) {

function addChecks(config: Config, platformName: string): CheckFunction[] {
if (platformName === config.ios.name) {
return [() => checkIOSPackage(config), () => checkBundler(config) || checkCocoaPods(config)];
return [() => checkIOSPackage(config), () => checkBundler(config), () => checkCocoaPods(config)];
} else if (platformName === config.android.name) {
return [() => checkAndroidPackage(config)];
} else if (platformName === config.web.name) {
Expand Down
3 changes: 2 additions & 1 deletion cli/src/tasks/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ export function updateChecks(config: Config, platforms: string[]): CheckFunction
const checks: CheckFunction[] = [];
for (const platformName of platforms) {
if (platformName === config.ios.name) {
checks.push(() => checkBundler(config) || checkCocoaPods(config));
checks.push(() => checkBundler(config));
checks.push(() => checkCocoaPods(config));
} else if (platformName === config.android.name) {
continue;
} else if (platformName === config.web.name) {
Expand Down