fix(android): Native timeout in watchPosition
#18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now the plugin has native timeout for
watchPositionon Android -> By updating native android geolocation lib to latest version 2.1.0.This aligns the behavior with
getCurrentPositionon Android, and also with iOS (recently addressed in a separate PR)Unlike in Capacitor plugin, we don't really have need to support
intervalparameter here, because the OutSystems plugin will have the same behavior as before; the difference being that for apps using this version of the plugin, the timeout is now handled on native side instead of in JavaScript wrapper layer.Context
Type of changes
Platforms affected
Tests
Can use the "Location Sample App" for Android on both O11 and ODC.
Now if you perform a
watchPositionand wait a number of seconds >timeoutto grant location permission, it will no longer timeout instantly, because the timeout does not run on JS anymore, but rather natively after permission request.