docs(select): add modal interface to ion-select docs
#3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tanner-reits
commented
Oct 31, 2024
Comment on lines
+170
to
+171
| The `modal` interface has a single `Close` button in the header. This button is only responsible for dismissing the modal. Any selections made will persist | ||
| after clicking this button or if the modal is dismissed using an alternative method. |
There was a problem hiding this comment.
I didn't update the playground despite adding this section since the "close" button isn't customizable
Comment on lines
-210
to
-214
| Customizing the interface dialog should be done by following the Customization section in that interface's documentation: | ||
| Customizing the interface dialog should be done by following the styling sections (CSS shadow parts, CSS custom properties, and slots) in | ||
| that interface's documentation: | ||
|
|
||
| - [Alert Customization](alert.md#customization) | ||
| - [Action Sheet Customization](action-sheet.md#customization) | ||
| - [Popover Customization](popover.md#customization) |
There was a problem hiding this comment.
These links didn't exist anymore, so tried to update this section to point users in the right direction
brandyscarney
approved these changes
Nov 1, 2024
thetaPC
approved these changes
Nov 1, 2024
Comment on lines
+110
to
+115
| ### Modal | ||
|
|
||
| import ModalExample from '@site/static/usage/v8/select/interfaces/modal/index.md'; | ||
|
|
||
| <ModalExample /> | ||
|
|
There was a problem hiding this comment.
Suggestion: Move this before Popover so it's alphabetic.
| - [Alert](alert.md#css-shadow-parts) | ||
| - [Action Sheet](action-sheet.md#css-shadow-parts) | ||
| - [Popover](popover.md#css-shadow-parts) | ||
| - [Modal](modal.md#css-shadow-parts) |
There was a problem hiding this comment.
Suggestion: Move this before Popover so it's alphabetic.
Comment on lines
+53
to
+59
| <ion-item> | ||
| <ion-select label="Modal" id="customModalSelect" interface="modal" placeholder="Select One"> | ||
| <ion-select-option value="reese's">Reese's</ion-select-option> | ||
| <ion-select-option value="snickers">Snickers</ion-select-option> | ||
| <ion-select-option value="twix">Twix</ion-select-option> | ||
| </ion-select> | ||
| </ion-item> |
There was a problem hiding this comment.
Suggestion: Move this before Popover so it's alphabetic.
tanner-reits
added a commit
that referenced
this pull request
Nov 4, 2024
* docs(select): update select docs for modal interface * fix(select): point playground to correct demo
tanner-reits
added a commit
that referenced
this pull request
Nov 4, 2024
* docs(select): add `modal` interface to `ion-select` docs (#3872) * docs(select): update select docs for modal interface * fix(select): point playground to correct demo * feat(segment): add playground & docs for segment view (#3875) * feat(segment): add playground & docs for segment view * fix(segment-view): api import version * fix(segment-content): usage & common API sections * Force CI run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: These docs are for an unreleased feature, to test, please update the version used by the playground to the following dev build:
8.3.4-dev.11730315987.18af6259What's Changed:
modalinterface where appropriatemodalinterface playgroundmodaltypeAssociated feature PR: ionic-team/ionic-framework#29972